debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Plug two filename leaks in the web cache

Browse source
This commit is contained in:
Christian Dywan 2009-10-26 23:46:21 +01:00
parent aff65928b3
commit 0eec63762f
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
extensions/web-cache.c
View file

@ -133,6 +133,8 @@ web_cache_save_headers (SoupMessage* msg,
while (soup_message_headers_iter_next (&iter, &name, &value)) while (soup_message_headers_iter_next (&iter, &name, &value))
g_fprintf (dscfd, "%s: %s\n", name, value); g_fprintf (dscfd, "%s: %s\n", name, value);
fclose (dscfd); fclose (dscfd);
g_free (dsc_filename);
} }
GHashTable* GHashTable*
@ -271,6 +273,7 @@ web_cache_mesage_got_headers_cb (SoupMessage* msg,
G_REGEX_CASELESS, G_REGEX_MATCH_NOTEMPTY)) G_REGEX_CASELESS, G_REGEX_MATCH_NOTEMPTY))
{ {
g_free (uri); g_free (uri);
g_free (filename);
return; return;
} }
} }
@ -281,17 +284,17 @@ web_cache_mesage_got_headers_cb (SoupMessage* msg,
g_signal_handlers_disconnect_by_func (msg, g_signal_handlers_disconnect_by_func (msg,
web_cache_mesage_got_headers_cb, extension); web_cache_mesage_got_headers_cb, extension);
web_cache_message_rewrite (msg, filename); web_cache_message_rewrite (msg, filename);
g_free (filename);
} }
else if (msg->status_code == SOUP_STATUS_OK) else if (msg->status_code == SOUP_STATUS_OK)
{ {
/* g_debug ("updating cache: %s -> %s", uri, filename); */ /* g_debug ("updating cache: %s -> %s", uri, filename); */
web_cache_save_headers (msg, filename); web_cache_save_headers (msg, filename);
/* FIXME: Do we need to disconnect signal after we are in unqueue? */ /* FIXME: Do we need to disconnect signal after we are in unqueue? */
g_signal_connect (msg, "got-chunk", g_signal_connect_data (msg, "got-chunk",
G_CALLBACK (web_cache_message_got_chunk_cb), filename); G_CALLBACK (web_cache_message_got_chunk_cb),
filename, (GClosureNotify)g_free, 0);
} }
/* FIXME: how to free this?
g_free (filename); */
g_free (uri); g_free (uri);
} }