debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't leak blockcss but free it before replacing it

Browse source
This commit is contained in:
Christian Dywan 2009-10-09 17:17:26 +02:00
parent 2718e47ca0
commit 223e9be7e3
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
extensions/adblock.c
View file

@ -23,7 +23,7 @@
#if WEBKIT_CHECK_VERSION (1, 1, 14) #if WEBKIT_CHECK_VERSION (1, 1, 14)
static GHashTable* pattern; static GHashTable* pattern;
static gchar* blockcss = ""; static gchar* blockcss = NULL;
static void static void
adblock_parse_file (gchar* path); adblock_parse_file (gchar* path);
@ -97,7 +97,7 @@ adblock_reload_rules (MidoriExtension* extension)
pattern = g_hash_table_new_full (g_str_hash, g_str_equal, pattern = g_hash_table_new_full (g_str_hash, g_str_equal,
(GDestroyNotify)g_free, (GDestroyNotify)g_free,
(GDestroyNotify)g_regex_unref); (GDestroyNotify)g_regex_unref);
blockcss = ""; katze_assign (blockcss, NULL);
while (filters[i++] != NULL) while (filters[i++] != NULL)
{ {
@ -467,9 +467,13 @@ adblock_app_add_browser_cb (MidoriApp* app,
static void static void
adblock_frame_add (gchar* line) adblock_frame_add (gchar* line)
{ {
gchar* new_blockcss;
(void)*line++; (void)*line++;
(void)*line++; (void)*line++;
blockcss = g_strdup_printf ("%s %s { display: none !important; }",blockcss,line); new_blockcss = g_strdup_printf ("%s %s { display: none !important; }",
blockcss, line);
katze_assign (blockcss, new_blockcss);
} }
static gchar* static gchar*
@ -568,7 +572,7 @@ adblock_deactivate_cb (MidoriExtension* extension,
app, adblock_app_add_browser_cb, extension); app, adblock_app_add_browser_cb, extension);
midori_browser_foreach (browser, (GtkCallback)adblock_deactivate_tabs, browser); midori_browser_foreach (browser, (GtkCallback)adblock_deactivate_tabs, browser);
blockcss = ""; katze_assign (blockcss, NULL);
g_hash_table_destroy (pattern); g_hash_table_destroy (pattern);
} }