debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Display error dialog on external download failure

Browse source
This commit is contained in:
André Stösel 2012-04-05 22:55:40 +02:00 committed by Christian Dywan
parent c4d1a96ca4
commit 2377ee3c94
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
extensions/external-download-manager.vala
View file

@ -113,6 +113,21 @@ namespace EDM {
manager.deactivated (this); manager.deactivated (this);
} }
public void handle_exception (GLib.Error error) {
string ext_name;
this.get ("name",out ext_name);
var dialog = new MessageDialog (null, DialogFlags.MODAL,
MessageType.ERROR, ButtonsType.CLOSE,
_("An error occurred when attempting to download a file with the following plugin:\n" +
"%s\n\n" +
"Error:\n%s\n\n" +
"Carry on without this plugin."
),
ext_name, error.message);
dialog.response.connect ((a) => { dialog.destroy (); });
dialog.run ();
}
public abstract bool download (DownloadRequest dlReq); public abstract bool download (DownloadRequest dlReq);
} }
@ -146,7 +161,7 @@ namespace EDM {
XMLRPC.parse_method_response ((string) message.response_body.flatten ().data, -1, out v); XMLRPC.parse_method_response ((string) message.response_body.flatten ().data, -1, out v);
return true; return true;
} catch (Error e) { } catch (Error e) {
stderr.printf ("Error while processing the response: %s\n", e.message); this.handle_exception (e);
} }
return false; return false;
@ -174,7 +189,7 @@ namespace EDM {
dm.AddFile (dlReq.uri); dm.AddFile (dlReq.uri);
return true; return true;
} catch (Error e) { } catch (Error e) {
stderr.printf("Error: %s\n", e.message); this.handle_exception (e);
} }
return false; return false;
} }