debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't quote arguments given to g_file_new_for_commandline_arg

Browse source
This commit is contained in:
Christian Dywan 2009-11-08 14:35:45 +01:00
parent f980d5ad91
commit 4dbc02d444
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
midori/sokoke.c
View file

@ -146,7 +146,6 @@ sokoke_spawn_program (const gchar* command,
const gchar* argument, const gchar* argument,
gboolean quote) gboolean quote)
{ {
gchar* argument_escaped;
GAppInfo* info; GAppInfo* info;
GFile* file; GFile* file;
GList* files; GList* files;
@ -154,12 +153,11 @@ sokoke_spawn_program (const gchar* command,
g_return_val_if_fail (command != NULL, FALSE); g_return_val_if_fail (command != NULL, FALSE);
g_return_val_if_fail (argument != NULL, FALSE); g_return_val_if_fail (argument != NULL, FALSE);
/* quote is ignored */
argument_escaped = quote ? g_shell_quote (argument) : g_strdup (argument);
info = g_app_info_create_from_commandline (command, info = g_app_info_create_from_commandline (command,
NULL, G_APP_INFO_CREATE_NONE, NULL); NULL, G_APP_INFO_CREATE_NONE, NULL);
file = g_file_new_for_commandline_arg (argument_escaped); file = g_file_new_for_commandline_arg (argument);
files = g_list_append (NULL, file); files = g_list_append (NULL, file);
error = NULL; error = NULL;
@ -167,13 +165,11 @@ sokoke_spawn_program (const gchar* command,
{ {
error_dialog (_("Could not run external program."), error->message); error_dialog (_("Could not run external program."), error->message);
g_error_free (error); g_error_free (error);
g_free (argument_escaped);
g_object_unref (file); g_object_unref (file);
g_list_free (files); g_list_free (files);
return FALSE; return FALSE;
} }
g_free (argument_escaped);
g_object_unref (file); g_object_unref (file);
g_list_free (files); g_list_free (files);
return TRUE; return TRUE;