debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove pointless FIXME and TODO comments from Midori classes

Browse source
This commit is contained in:
Christian Dywan 2010-09-12 20:23:39 +02:00
parent db6e5954e8
commit d34da1c500
5 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
midori/midori-app.c
View file

@ -777,23 +777,18 @@ midori_app_set_property (GObject* object,
break; break;
case PROP_SETTINGS: case PROP_SETTINGS:
katze_object_assign (app->settings, g_value_dup_object (value)); katze_object_assign (app->settings, g_value_dup_object (value));
/* FIXME: Propagate settings to all browsers */
break; break;
case PROP_BOOKMARKS: case PROP_BOOKMARKS:
katze_object_assign (app->bookmarks, g_value_dup_object (value)); katze_object_assign (app->bookmarks, g_value_dup_object (value));
/* FIXME: Propagate bookmarks to all browsers */
break; break;
case PROP_TRASH: case PROP_TRASH:
katze_object_assign (app->trash, g_value_dup_object (value)); katze_object_assign (app->trash, g_value_dup_object (value));
/* FIXME: Propagate trash to all browsers */
break; break;
case PROP_SEARCH_ENGINES: case PROP_SEARCH_ENGINES:
katze_object_assign (app->search_engines, g_value_dup_object (value)); katze_object_assign (app->search_engines, g_value_dup_object (value));
/* FIXME: Propagate search engines to all browsers */
break; break;
case PROP_HISTORY: case PROP_HISTORY:
katze_object_assign (app->history, g_value_dup_object (value)); katze_object_assign (app->history, g_value_dup_object (value));
/* FIXME: Propagate history to all browsers */
break; break;
case PROP_EXTENSIONS: case PROP_EXTENSIONS:
katze_object_assign (app->extensions, g_value_dup_object (value)); katze_object_assign (app->extensions, g_value_dup_object (value));

5
midori/midori-browser.c
View file

@ -2131,7 +2131,6 @@ _action_private_browsing_activate (GtkAction* action,
const gchar* uri = midori_browser_get_current_uri (browser); const gchar* uri = midori_browser_get_current_uri (browser);
if (uri != NULL) if (uri != NULL)
{ {
/* FIXME: Use the same binary that is running right now */
if (*uri != '\0') if (*uri != '\0')
midori_browser_spawn_app (uri); midori_browser_spawn_app (uri);
else else
@ -2748,7 +2747,6 @@ midori_browser_open_bookmark (MidoriBrowser* browser,
if (!uri_fixed) if (!uri_fixed)
uri_fixed = g_strdup (uri); uri_fixed = g_strdup (uri);
/* FIXME: Use the same binary that is running right now */
if (katze_item_get_meta_boolean (item, "app")) if (katze_item_get_meta_boolean (item, "app"))
midori_browser_spawn_app (uri_fixed); midori_browser_spawn_app (uri_fixed);
else else
@ -3225,7 +3223,6 @@ midori_browser_source_transfer_cb (KatzeNetRequest* request,
fclose (fp); fclose (fp);
if ((ret - request->length) != 0) if ((ret - request->length) != 0)
{ {
/* FIXME: Show an error in the graphical interface */
g_warning ("Error writing to file %s " g_warning ("Error writing to file %s "
"in midori_browser_source_transfer_cb()", filename); "in midori_browser_source_transfer_cb()", filename);
} }
@ -3279,7 +3276,6 @@ _action_source_view_activate (GtkAction* action,
#else #else
GError* error = NULL; GError* error = NULL;
/* FIXME: Handling http transparently in the function would be nice */
if (g_str_has_prefix (uri, "file://")) if (g_str_has_prefix (uri, "file://"))
{ {
if (!sokoke_show_uri_with_mime_type (gtk_widget_get_screen (view), if (!sokoke_show_uri_with_mime_type (gtk_widget_get_screen (view),
@ -5577,7 +5573,6 @@ midori_browser_init (MidoriBrowser* browser)
error = NULL; error = NULL;
if (!gtk_ui_manager_add_ui_from_string (ui_manager, ui_markup, -1, &error)) if (!gtk_ui_manager_add_ui_from_string (ui_manager, ui_markup, -1, &error))
{ {
/* TODO: Should this be a message dialog? When does this happen? */
g_message ("User interface couldn't be created: %s", error->message); g_message ("User interface couldn't be created: %s", error->message);
g_error_free (error); g_error_free (error);
} }

1
midori/midori-locationaction.c
View file

@ -545,7 +545,6 @@ midori_location_action_popup_completion (MidoriLocationAction* action,
G_CALLBACK (gtk_widget_destroyed), &action->entry); G_CALLBACK (gtk_widget_destroyed), &action->entry);
action->completion_timeout = g_timeout_add (COMPLETION_DELAY, action->completion_timeout = g_timeout_add (COMPLETION_DELAY,
midori_location_action_popup_timeout_cb, action); midori_location_action_popup_timeout_cb, action);
/* TODO: Inline completion */
} }
static void static void

1
midori/midori-preferences.c
View file

@ -420,7 +420,6 @@ midori_preferences_set_settings (MidoriPreferences* preferences,
#endif #endif
#if WEBKIT_CHECK_VERSION (1, 1, 6) #if WEBKIT_CHECK_VERSION (1, 1, 6)
FRAME_NEW (_("Spell Checking")); FRAME_NEW (_("Spell Checking"));
/* FIXME: Provide a nice dictionary selection */
button = katze_property_proxy (settings, "enable-spell-checking", NULL); button = katze_property_proxy (settings, "enable-spell-checking", NULL);
gtk_button_set_label (GTK_BUTTON (button), _("Enable Spell Checking")); gtk_button_set_label (GTK_BUTTON (button), _("Enable Spell Checking"));
gtk_widget_set_tooltip_text (button, _("Enable spell checking while typing")); gtk_widget_set_tooltip_text (button, _("Enable spell checking while typing"));

1
midori/midori-view.c
View file

@ -1669,7 +1669,6 @@ static void
midori_web_view_menu_web_app_activate_cb (GtkWidget* widget, midori_web_view_menu_web_app_activate_cb (GtkWidget* widget,
MidoriView* view) MidoriView* view)
{ {
/* FIXME: Use the same binary that is running right now */
sokoke_spawn_program ("midori -a", view->link_uri, FALSE); sokoke_spawn_program ("midori -a", view->link_uri, FALSE);
} }