debian/midori
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove window flashing on new tabs

Browse source 
The flashing can be distracting to some users. We
may re-visit the feature if we find a better behavior.

The setting stays to avoid resetting old config files.
This commit is contained in:
Christian Dywan 2012-07-01 22:00:23 +02:00
parent 4e51fa1f00
commit ef4ee2f634
3 changed files with 8 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
midori/midori-browser.c
View file

@ -1249,23 +1249,6 @@ midori_browser_view_copy_history (GtkWidget* view_to,
} }
} }
static gboolean
midori_browser_notify_new_tab_timeout_cb (MidoriBrowser *browser)
{
gtk_window_set_opacity (GTK_WINDOW (browser), 1);
return G_SOURCE_REMOVE;
}
static void
midori_browser_notify_new_tab (MidoriBrowser *browser)
{
if (katze_object_get_boolean (browser->settings, "flash-window-on-new-bg-tabs"))
{
gtk_window_set_opacity (GTK_WINDOW (browser), 0.8);
g_timeout_add (100, (GSourceFunc) midori_browser_notify_new_tab_timeout_cb, browser);
}
}
static void static void
midori_view_new_tab_cb (GtkWidget* view, midori_view_new_tab_cb (GtkWidget* view,
const gchar* uri, const gchar* uri,
@ -1278,8 +1261,6 @@ midori_view_new_tab_cb (GtkWidget* view,
if (!background) if (!background)
midori_browser_set_current_page (browser, n); midori_browser_set_current_page (browser, n);
else
midori_browser_notify_new_tab (browser);
} }
static void static void
@ -1315,8 +1296,6 @@ midori_view_new_view_cb (GtkWidget* view,
gint n = midori_browser_add_tab (browser, new_view); gint n = midori_browser_add_tab (browser, new_view);
if (where != MIDORI_NEW_VIEW_BACKGROUND) if (where != MIDORI_NEW_VIEW_BACKGROUND)
midori_browser_set_current_page (browser, n); midori_browser_set_current_page (browser, n);
else
midori_browser_notify_new_tab (browser);
} }
if (!user_initiated) if (!user_initiated)

5
midori/midori-preferences.c
View file

@ -392,13 +392,10 @@ midori_preferences_set_settings (MidoriPreferences* preferences,
else else
button = katze_property_proxy (settings, "middle-click-opens-selection", NULL); button = katze_property_proxy (settings, "middle-click-opens-selection", NULL);
INDENTED_ADD (button); INDENTED_ADD (button);
button = katze_property_proxy (settings, "flash-window-on-new-bg-tabs", NULL);
SPANNED_ADD (button);
if (katze_object_has_property (settings, "enable-webgl")) if (katze_object_has_property (settings, "enable-webgl"))
{ {
button = katze_property_proxy (settings, "enable-webgl", NULL); button = katze_property_proxy (settings, "enable-webgl", NULL);
INDENTED_ADD (button); SPANNED_ADD (button);
} }
FRAME_NEW (NULL); FRAME_NEW (NULL);

7
midori/midori-websettings.c
View file

@ -822,6 +822,13 @@ midori_web_settings_class_init (MidoriWebSettingsClass* class)
!midori_web_settings_low_memory_profile (), !midori_web_settings_low_memory_profile (),
flags)); flags));
#endif #endif
/**
* MidoriWebSettings::flash-window-on-new-bg-tabs
*
* Doesn't do anything.
*
* Deprecated: 0.4.7
*/
g_object_class_install_property (gobject_class, g_object_class_install_property (gobject_class,
PROP_FLASH_WINDOW_ON_BG_TABS, PROP_FLASH_WINDOW_ON_BG_TABS,
g_param_spec_boolean ( g_param_spec_boolean (